BZ#1446408 -filter tooltip overflow #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskacerguis
approved these changes
May 11, 2017
|
Checked commit AllenBW@84c19c7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
LGTM. Have you guys already bumped your version of Angular PF? I think it was just released on 5/10th (https://github.com/patternfly/angular-patternfly/releases/tag/v3.24.0) |
|
Yup, it was bumped as part of this PR. |
|
@serenamarie125 could you please add your approval? |
serenamarie125
approved these changes
May 12, 2017
|
@AllenBW there is a conflict backporting to Fine branch. Please confirm ++<<<<<<< HEAD
+ "angular-patternfly": "3.23.2",
++=======
+ "angular-patternfly": "^3.24.0",
++>>>>>>> af8b601... Merge pull request #753 from AllenBW/BZ/#1446408-filtertooltipoverflow |
|
@AllenBW so just |
|
Removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1446408
patternfly/angular-patternfly#456
https://www.pivotaltracker.com/story/show/144523025
Screenshots are in the patternfly pr