Adds "View Graphs" link to service details #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transitions user to vms-details state with a defalut viewType specified At the moment, graphs component does not appear to be working correctly, can't handle being the default view, following up with pr to fix
AllenBW
force-pushed
the
PT/#146157721-graphView-service-details-link
branch
from
26fce93
to
1d2c5d9
Compare
|
Checked commit AllenBW@1d2c5d9 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@serenamarie125 @AllenBW Should we really call this "View Graph"?? and not "Utilisation" like in Ops UI... Graph is really generic |
|
@Loicavenel can call it whateva yo ❤️ desires, just 🗣 the 🔠 |
chriskacerguis
approved these changes
Jun 19, 2017
chalettu
approved these changes
Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/146157721
Transitions user to vms-details state with a defalut viewType specified
At the moment, graphs component does not appear to be working correctly, can't handle being the default view, following up with pr to fix
gif of the bug i'll be working on next