Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BZ#145848583 - Introduce service tag filtering #840

Merged
merged 5 commits into from
Jul 27, 2017
Merged

BZ#145848583 - Introduce service tag filtering #840

merged 5 commits into from
Jul 27, 2017
+196 −191

Commits on Jul 27, 2017

  1. Conflicting eslint errors resolved 

    arrow-body-style would say its an expression no need for return and no-confusing-arrow would say its a confusing expression it needs a return, opting for the less invasive of the two, expressions should be encapsulated in params
    @AllenBW
    AllenBW committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    056ecd5 View commit details
    Browse the repository at this point in the history

  2. Adds option to filter services by tags [Finishes #145848583] 

    Right now, api doesn't handle anding together multiple tag filters, when it supports, filtering by multiple tags will work outta da box
    @AllenBW
    AllenBW committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    1f9973e View commit details
    Browse the repository at this point in the history

  3. Increase dropdown size to be total filter bar width

    @AllenBW
    AllenBW committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    077b491 View commit details
    Browse the repository at this point in the history

  4. Simplify service resolve 

    Need to rework polling on this, as it stands it a flashback whenever conents are filtered or sorted
    @AllenBW
    AllenBW committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    615d42b View commit details
    Browse the repository at this point in the history

  5. Reconfigure polling to prevent ghosting, meaningful error feedback 

    We stop polling whenever a new request for resources has been made (or the component is destroyed)
After successfully grabbing these new resources, we begin polling on the successful call
This avoids the previous issue of stale polling
    @AllenBW
    AllenBW committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    1c9844d View commit details
    Browse the repository at this point in the history