[Finishes #149501873] Added ui-components Dialog to SUI #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No UX review required. Just adding our common dialog component into Service UI |
|
Checked commit https://github.com/chalettu/manageiq-ui-service/commit/82eb909e375155062bfce572a735a43ee1424de4 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@chalettu did this get reviewed in the ui-components repo? |
chriskacerguis
approved these changes
Aug 7, 2017
|
@chriskacerguis this did get reviewed in ui-components. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@miq-bot add_label fine/no
@miq-bot add_label catalogs / dialogs
@miq-bot add_label enhancement