[Finished #149938700] Updated custom button details to use Dialog Component #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commits https://github.com/chalettu/manageiq-ui-service/compare/603d6ae962d7159937f20b2e6eec016c7299ed7a~...5214d851ff3911ed9147c67b17d26937dd7ae0ed with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
AllenBW
approved these changes
Aug 17, 2017
There was a problem hiding this comment.
LGTM though that commit message should be reworded to Finishes or[(Finishes|Fixes|Delivers) #TRACKER_STORY_ID] https://www.pivotaltracker.com/help/articles/githubs_service_hook_for_tracker/
chriskacerguis
approved these changes
Aug 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@miq-bot add_label enhancement
@miq-bot add_label fine/no
@miq-bot add_label my services