Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated service reconfigure to use dialog component #877

Merged
merged 3 commits into from
Aug 21, 2017
Merged

Updated service reconfigure to use dialog component #877

merged 3 commits into from
Aug 21, 2017

Conversation

chalettu
Copy link
Contributor

@miq-bot add_label enhancement
@miq-bot add_label fine/no

@AllenBW AllenBW added this to the Sprint 67 Ending Aug 21, 2017 milestone Aug 18, 2017
AllenBW
AllenBW suggested changes Aug 18, 2017
View reviewed changes
Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chalettu I knoooooow this updating old work, but can we get ss of before and after here?

THAT aside LOVE THIS pulling out so much old for just a little new

@chriskacerguis chriskacerguis self-assigned this Aug 18, 2017
chriskacerguis
chriskacerguis suggested changes Aug 18, 2017
View reviewed changes
Copy link
Contributor

@chriskacerguis chriskacerguis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code coverage dropped (a tiny bit) anything that can be done to either neutral it out or make it go up?

@miq-bot
Copy link
Member

miq-bot commented Aug 18, 2017

Checked commits https://github.com/chalettu/manageiq-ui-service/compare/849568e4269d0ea14c1db3ccf0ca0eae75e69c8d~...78a6c17c2546eec75b623f93c4cc637debd17359 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@chalettu
Copy link
Contributor Author

reconfigure

@chalettu
Copy link
Contributor Author

@chriskacerguis , got testing to go back up a little bit.

@chalettu
Copy link
Contributor Author

@AllenBW , I added a SS as requested.

AllenBW
AllenBW approved these changes Aug 18, 2017
View reviewed changes
Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ 🙇‍♀️

@chriskacerguis chriskacerguis merged commit 490973b into ManageIQ:master Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskacerguis chriskacerguis chriskacerguis approved these changes

@AllenBW AllenBW AllenBW approved these changes

Assignees

@chriskacerguis chriskacerguis

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chalettu @miq-bot @chriskacerguis @AllenBW