Ensure unique url for service.resource-details, update all instances #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit AllenBW@bb43ead with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
chalettu
reviewed
Aug 31, 2017
| @@ -6,7 +6,7 @@ export function VmsDetailsState (routerHelper) { | |||
| function getStates () { | |||
| return { | |||
| 'services.resource-details': { | |||
| url: '/:vmId', | |||
| url: '/:serviceId/resource=:vmId', | |||
| params: { viewType: null }, | |||
| template: '<vm-details>', | |||
| title: N_('Resource Details') | |||
There was a problem hiding this comment.
Not related to this PR but I have been slowly replacing N_ with __ wherever I find them.
|
@chriskacerguis 👀 🙇♀️ |
chriskacerguis
approved these changes
Sep 5, 2017
AllenBW
deleted the
enhancement/ensure-unique-url-for-resource-details-state
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In support of a task in this pt: https://www.pivotaltracker.com/story/show/147640893
No UX? I don't know what counts anymore, seems to me to be just a simple url change
TL;DR
services.resource-detailsnow has url of/services/:serviceId/resource=:vmId(used to be/services/:vmId)This was getting terribly annoying, refreshing the resource details page only to have this happen:
Cuz our resource details url isn't unique 😭
Before: can you tell which one is a service details vs a resource details?
After: unique! also doesn't mind being reloaded or navigated to directly (via url)