Force codemirror to 5.19.* #12077
Merged
Force codemirror to 5.19.* #12077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemirror-5.20.0 came out today, which abandons the es5 source file in favour of es6 source that has to be compiled. We don't support that yet, forcing the version to the last one working.
|
Checked commit https://github.com/himdel/manageiq/commit/dcec93003cc1e88a4f1662baeaa16cb649624c0a with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
skateman
approved these changes
Oct 20, 2016
chessbyte
pushed a commit
that referenced
this pull request
Oct 21, 2016
Force codemirror to 5.19.* (cherry picked from commit 98fd1d4)
|
Euwe Backport details: $ git log -1
commit 7b920e75dafc2a7beb1845189180cc685be95178
Author: Milan Zázrivec <[email protected]>
Date: Thu Oct 20 16:48:45 2016 +0200
Merge pull request #12077 from himdel/bower-codemirror
Force codemirror to 5.19.*
(cherry picked from commit 98fd1d46ba12211c3ca2f97cb21c326d9addaf13) |
chessbyte
pushed a commit
that referenced
this pull request
Nov 3, 2016
Force codemirror to 5.19.* (cherry picked from commit 98fd1d4)
|
Darga Backport details: $ git log -1
commit 5fe68236a155f3124fea88737b41f2778adb09a4
Author: Milan Zázrivec <[email protected]>
Date: Thu Oct 20 16:48:45 2016 +0200
Merge pull request #12077 from himdel/bower-codemirror
Force codemirror to 5.19.*
(cherry picked from commit 98fd1d46ba12211c3ca2f97cb21c326d9addaf13) |
jameswnl
pushed a commit
to jameswnl/manageiq
that referenced
this pull request
Dec 1, 2016
given the recent codemirror breakage (ManageIQ#12077), I'm updating our `bower.json` to always use `~` for dependencies (`~1.2.3` is `>= 1.2.3 && < 1.3.0`, whereas `^1.2.3` is `>= 1.2.3`). But since evererthing else is working at the current versions, also updated to the newest being used (except for codemirror).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codemirror-5.20.0 came out today, which abandons the es5 source file in favour of es6 source that has to be compiled.
We don't support that yet, forcing the version to the last one working.
Tagging as
euwe/yesanddarga/yes, because without this, any new build will have codemirror broken. (We had a badly fixed dependency,^means anything newer, not the same minor version.)Cc @simaishi