Add delete functionality for generic object UI #12102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eclarizio
force-pushed
the
generic_object_delete
branch
from
87aa994
to
b77e42c
Compare
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
https://www.pivotaltracker.com/story/show/128427247 Also shorten eventType from 'sendCountSelectedAndUpdateToolbar' to 'updateToolbarCount'.
eclarizio
force-pushed
the
generic_object_delete
branch
from
b77e42c
to
2df237f
Compare
|
Checked commits eclarizio/manageiq@7083894~...2df237f with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
|
Please re-create this PR in https://github.com/ManageIQ/manageiq-ui-classic |
|
@chessbyte Will do, currently waiting for ManageIQ/manageiq-ui-classic#72 to be merged as this is built on that and it should make fixing the conflicts easier. |
This was referenced Jan 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was built on top of #11815, so once that is merged, the first four commits here will disappear.
This enables the user to delete a selected generic object definitions via the configuration drop-down.
Before deletion:
After deletion:
https://www.pivotaltracker.com/story/show/129980083
@miq-bot assign @gmcculloug