Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register VMDB plugins #12221

Merged
merged 1 commit into from
Oct 26, 2016
Merged

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Oct 26, 2016

Extracted from #11083

@bdunne
Copy link
Member Author

bdunne commented Oct 26, 2016

@Fryguy Please review

@bdunne bdunne force-pushed the provider_plugin_registration branch from 675500c to 83300fb Compare October 26, 2016 20:17
@miq-bot
Copy link
Member

miq-bot commented Oct 26, 2016

Checked commit bdunne@83300fb with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
2 files checked, 1 offense detected

config/initializers/register_vmdb_plugins.rb

@Fryguy
Copy link
Member

Fryguy commented Oct 26, 2016

LGTM 👍

cc @durandom

@Fryguy Fryguy merged commit e1587da into ManageIQ:master Oct 26, 2016
@Fryguy Fryguy added this to the Sprint 49 Ending Nov 14, 2016 milestone Oct 26, 2016
@durandom
Copy link
Member

Yay ❤️ 💟 @bdunne @Fryguy

Now off to move settings in providers forward

@bdunne bdunne deleted the provider_plugin_registration branch October 27, 2016 13:44
@durandom
Copy link
Member

@bdunne any idea if we can prevent reload! clearing the instance?

[4] pry(main)> Vmdb::Plugins.instance.vmdb_plugins.count
=> 1
[5] pry(main)> reload!
Reloading...
=> true
[6] pry(main)> Vmdb::Plugins.instance.vmdb_plugins.count
=> 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants