Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Azure provision template to restrict VM names #12947

Merged
merged 2 commits into from
Dec 6, 2016
Merged

Update Azure provision template to restrict VM names #12947

merged 2 commits into from
Dec 6, 2016

Conversation

djberg96
Copy link
Contributor

@djberg96 djberg96 commented Dec 1, 2016

This adds a VM name constraint to the Azure provisioning dialog, restricting it to alphanumeric characters, hyphens and underscores, with a range of 1-15 characters. Some additional restrictions have also been included regarding leading and trailing characters.

Addresses https://bugzilla.redhat.com/show_bug.cgi?id=1377889

image

@jteehan
Copy link

jteehan commented Dec 1, 2016

I was just looking at this. There are a few other less obvious restrictions like the username can't be "root" or "Administrator" The most common error is an invalid password but MS keeps changing those rules frequently, but maybe the length restriction could be added.

Password restrictions
8 characters minimum and 16 characters maximum
Strong passwords only: Requires 3 out of 4 of the following:
Lowercase characters
Uppercase characters
Numbers (0-9)
Symbols (see password restrictions above)

@djberg96 djberg96 changed the title Provision template Update Azure provision template to restrict VM names Dec 1, 2016
@djberg96
Copy link
Contributor Author

djberg96 commented Dec 1, 2016

@jteehan This is just for VM names, not admin names and passwords. That will be a separate PR.

@djberg96 djberg96 changed the title Update Azure provision template to restrict VM names [WIP] Update Azure provision template to restrict VM names Dec 1, 2016
@djberg96
Copy link
Contributor Author

djberg96 commented Dec 1, 2016

@miq-bot add_label wip

@miq-bot miq-bot added the wip label Dec 1, 2016
@djberg96
Copy link
Contributor Author

djberg96 commented Dec 1, 2016

Need to look at this some more, it seems to treat valid names as invalid for some reason.

@djberg96 djberg96 changed the title [WIP] Update Azure provision template to restrict VM names Update Azure provision template to restrict VM names Dec 1, 2016
@djberg96
Copy link
Contributor Author

djberg96 commented Dec 1, 2016

Turns out it was just a matter of fixing "regexp".

@djberg96
Copy link
Contributor Author

djberg96 commented Dec 1, 2016

@miq-bot remove_label wip

@djberg96
Copy link
Contributor Author

djberg96 commented Dec 5, 2016

@miq-bot add_label euwe/yes

@djberg96
Copy link
Contributor Author

djberg96 commented Dec 5, 2016

@gmcculloug Look alright?

@gmcculloug gmcculloug merged commit 5f9094f into ManageIQ:master Dec 6, 2016
@gmcculloug gmcculloug added this to the Sprint 51 Ending Jan 2, 2017 milestone Dec 6, 2016
simaishi pushed a commit that referenced this pull request Jan 9, 2017
Update Azure provision template to restrict VM names
(cherry picked from commit 5f9094f)

https://bugzilla.redhat.com/show_bug.cgi?id=1402528
@simaishi
Copy link
Contributor

simaishi commented Jan 9, 2017

Euwe backport details:

$ git log -1
commit 0f4142ff5b86bdc72f4cc60cf3090868b3228718
Author: Greg McCullough <[email protected]>
Date:   Tue Dec 6 10:10:10 2016 -0500

    Merge pull request #12947 from djberg96/provision_template
    
    Update Azure provision template to restrict VM names
    (cherry picked from commit 5f9094f3e2b9dd8fe5174e70bba36b51dade5982)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1402528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants