Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add list of providers to RBAC on catalog items #13395

Merged
merged 4 commits into from
Jan 10, 2017
Merged

Add list of providers to RBAC on catalog items #13395

merged 4 commits into from
Jan 10, 2017

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Jan 9, 2017 •
edited by miq-bot
Loading

Add list of providers to RBAC in catalog items.

In catalog items, providers are listed by method OrchestrationTemplate#eligible_managers,
so I added RBAC filtering here.

In UI list of providers in catalog items is here and here
 (there is changed eligible_managers):

screen shot 2017-01-09 at 10 39 30

Links

@miq-bot add_label bug, rbac
@miq-bot assign @gtanzillo

@lpichler
Where query works also with model classes
6cdf92a
@lpichler
Add RBAC to eligible_managers managers
b2e1972 
This list used in Service Catalog Item form
(Services -> Catalog Items -> Service Catalog Item)
@lpichler
Add admin user and distinguish provider by tenant
e58f428
@lpichler
Add case with user under different tenant
ec4bf51 
then list of providers is resctricted
@miq-bot
Copy link
Member

miq-bot commented Jan 9, 2017

Checked commits lpichler/manageiq@6cdf92a~...ec4bf51 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
2 files checked, 0 offenses detected
Everything looks good. 🍰

gtanzillo
gtanzillo approved these changes Jan 10, 2017
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@gtanzillo gtanzillo added this to the Sprint 52 Ending Jan 16, 2017 milestone Jan 10, 2017
@gtanzillo gtanzillo merged commit 2909905 into ManageIQ:master Jan 10, 2017
@lpichler lpichler deleted the add_list_of_providers_to_rbac_on_catalog_items branch January 10, 2017 14:42
@simaishi
Copy link
Contributor

Added euwe/yes as per the flag on the BZ.

simaishi pushed a commit that referenced this pull request Jan 18, 2017
@gtanzillo @simaishi
Merge pull request #13395 from lpichler/add_list_of_providers_to_rbac…
1db506b 
…_on_catalog_items

Add list of providers to RBAC on catalog items
(cherry picked from commit 2909905)

https://bugzilla.redhat.com/show_bug.cgi?id=1414012
@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit 1db506b3b903216c27b4d626eef1550479831fa7
Author: Gregg Tanzillo <[email protected]>
Date:   Tue Jan 10 09:41:23 2017 -0500

    Merge pull request #13395 from lpichler/add_list_of_providers_to_rbac_on_catalog_items
    
    Add list of providers to RBAC on catalog items
    (cherry picked from commit 2909905b477b83419744b85ee8dbf92943d6c0ea)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1414012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@gtanzillo gtanzillo

Labels
bug core/rbac euwe/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lpichler @miq-bot @simaishi @gtanzillo