[EUWE] ops_rbac - group detail - don't render trees that are not visible #13399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since #3859 (comment), `miq_tab_header` would put ng-click (hardcoded to call `changeAuthTab`) on every tab header, even though it makes no sense for most tabs Fixed by moving the ng-click value explicitly to options, and passing it from where `ng-click` is actually needed Also added :onclick to options, so that custom functionality can be added in non-angular tabs too. miq_tab_content now also takes a :lazy option, which causes the tab content to render only if the tab is currently active (cherry picked from commit 2b1da75)
plus some cleanup (cherry picked from commit a17448d)
..and enable the tabs to be lazy (cherry picked from commit eb96dc7)
only loaded once, then it's kept in the browser (so only the first time one switches to a tab, a round trip is needed) (cherry picked from commit 90b0e86)
a long line, and a trailing _ in array assignment (cherry picked from commit a7b219c)
…r lazy loading the tab otherwise, ManageIQ.record.recordId gets overwritten with null, causing the toolbar to generate an url without an id (cherry picked from commit fb3a0e7)
(cherry picked from commit a110791)
(cherry picked from commit c99485e)
technically cherry-picked from 01193c0 same change, different code
himdel
changed the title
mzazrivec
approved these changes
Jan 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an euwe version of ManageIQ/manageiq-ui-classic#68 - lazy-load right-side trees in rbac group detail.
https://bugzilla.redhat.com/show_bug.cgi?id=1399345
@miq-bot add_label ui, enhancement
@miq-bot assign chessbyte