Openstack infra ssh keypair validation fixes #13445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrblaho
force-pushed
the
openstack-infra-ssh-keypair-validation-fixes
branch
from
aec7bad
to
f5d161f
Compare
This adds ems_cluster_id checking when selecting Hosts for ssh key validation on OpenStack Infra Provider. Solves https://bugzilla.redhat.com/show_bug.cgi?id=1406443
petrblaho
force-pushed
the
openstack-infra-ssh-keypair-validation-fixes
branch
from
f5d161f
to
135abae
Compare
Adds ems_cluster association to host_openstack_infra Factory. Adds test to make sure that we skip Hosts without EmsCluster associated.
petrblaho
force-pushed
the
openstack-infra-ssh-keypair-validation-fixes
branch
from
135abae
to
740d3b6
Compare
|
Some comments on commits petrblaho/manageiq@40b1773~...740d3b6 spec/models/manageiq/providers/openstack/infra_manager_spec.rb
|
|
Checked commits petrblaho/manageiq@40b1773~...740d3b6 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 spec/factories/host.rb
spec/models/manageiq/providers/openstack/infra_manager_spec.rb
|
petrblaho
changed the title
This was referenced Jan 11, 2017
|
👍 looks good to me as the combination of two previous PRs! |
|
@miq-bot assign @blomquisg |
simaishi
pushed a commit
that referenced
this pull request
Jan 16, 2017
…validation-fixes Openstack infra ssh keypair validation fixes (cherry picked from commit df1fcf1) https://bugzilla.redhat.com/show_bug.cgi?id=1413207 https://bugzilla.redhat.com/show_bug.cgi?id=1413210
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are 2 fixes for OpenStack Infra SSH Key Pair validation code.
Contains code form #13159 and #13275
Solves:
https://bugzilla.redhat.com/show_bug.cgi?id=1376605
https://bugzilla.redhat.com/show_bug.cgi?id=1406443