Added new features for the Ansible UI move to the Automation tab #13526
Conversation
|
@miq-bot add_label ui, enhancement, wip |
lgalis
force-pushed
the
move_ansible_ui_to_automation_main
branch
7 times, most recently
from
9e90f68
to
f6df095
Compare
|
@dclarizio - please review |
lgalis
changed the title
|
@miq-bot remove_label wip |
| - :name: Ansible Tower | ||
| :description: Everything under Ansible Tower | ||
| :feature_type: node | ||
| :identifier: ansible_tower |
There was a problem hiding this comment.
I am really against us hardcoding this as ansible_tower. It should be reflected as AutomationManager, or, perhaps ExternalAutomationManager. The UI should never code to a specific provider but instead to the abstraction layer above it. cc @dclarizio @chessbyte
There was a problem hiding this comment.
@Fryguy - I agree - I had Automation Manager first, then discussed with @dclarizio and changed it to ansible_tower. I can change this to automation manager rather than external, and we can name the internal something else.
lgalis
force-pushed
the
move_ansible_ui_to_automation_main
branch
3 times, most recently
from
b3e7207
to
a4ac3f1
Compare
|
@Fryguy - updated |
| - :name: Configured Systems | ||
| :description: Everything under Configured Systems accordion | ||
| :feature_type: node | ||
| :identifier: automation_manager_cs_filter_accord |
There was a problem hiding this comment.
@lgalis Should this be abbreviated to _cs_? I'm asking because
- the ones below, like
automation_manager_configured_system_controlare not abbreviated, and I feel it should be consistent. - Abbreviation of
csforconfigured_systemcan be confused withconfiguration_script. Down below, configuration_script is spelled out (for view:automation_manager_configuration_script_control)
| - :name: Create Service Dialog | ||
| :description: Create Service Dialog | ||
| :feature_type: admin | ||
| :identifier: automation_manager_configscript_service_dialog |
There was a problem hiding this comment.
and this one is different in another way
| - :name: View | ||
| :description: View Configured Systems | ||
| :feature_type: view | ||
| :identifier: automation_manager_cs_filter_accord_view |
Rename feature to automation_manager
lgalis
force-pushed
the
move_ansible_ui_to_automation_main
branch
from
a4ac3f1
to
9a674bc
Compare
|
Checked commits lgalis/manageiq@7afe4b6~...33ae947 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@Fryguy - please review |
Added new features for the Ansible UI move to the Automation tab
Links [Optional]
https://www.pivotaltracker.com/n/projects/1937457/stories/137618573
This PR is required for ManageIQ/manageiq-ui-classic#170