Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EUWE] Upgrade azure-armrest gem to 0.5.2. #13670

Merged
merged 1 commit into from
Feb 1, 2017
Merged

[EUWE] Upgrade azure-armrest gem to 0.5.2. #13670

merged 1 commit into from
Feb 1, 2017

Conversation

djberg96
Copy link
Contributor

@djberg96 djberg96 commented Jan 26, 2017 •
edited by miq-bot
Loading

As part of the effort to get every branch on the same azure-armrest gem, this PR updates the gem to 0.5.2.

Currently gems-pending already has the dependency set to 0.5.2.

Also see #13311 and ManageIQ/manageiq-providers-azure#28

@miq-bot miq-bot changed the title Upgrade azure-armrest gem to 0.5.2. [EUWE] Upgrade azure-armrest gem to 0.5.2. Jan 26, 2017
@djberg96 djberg96 mentioned this pull request Jan 26, 2017
Merged
bronaghs
bronaghs suggested changes Jan 26, 2017
View reviewed changes
Copy link

@bronaghs bronaghs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djberg96 - For gems that are developed by ManageIQ we want to point to a specific gem version, so:"=0.5.2" instead of "~> 0.5.2". This means we can release a new version of a gem independent of upgrading manageiq to use it.

@djberg96
Copy link
Contributor Author

@bronaghs Done.

@bronaghs
Copy link

@miq-bot assign @blomquisg

@miq-bot
Copy link
Member

miq-bot commented Jan 26, 2017

Checked commit https://github.com/djberg96/manageiq/commit/04c31cab5f7086a7dec82727ba365df4b41eb6b5 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. 👍

@chessbyte chessbyte assigned simaishi and unassigned blomquisg Jan 27, 2017
@simaishi simaishi merged commit f76b06b into ManageIQ:euwe Feb 1, 2017
@simaishi simaishi added this to the Sprint 54 Ending Feb 13, 2017 milestone Feb 1, 2017
@simaishi
Copy link
Contributor

simaishi commented Feb 1, 2017

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1404827

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bronaghs bronaghs bronaghs requested changes

@blomquisg blomquisg blomquisg approved these changes

Assignees

@simaishi simaishi

Labels
blocker dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@djberg96 @bronaghs @miq-bot @simaishi @blomquisg