Initial commit for ansible playbook methods and service model. #13717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzwei
reviewed
Feb 1, 2017
| @@ -0,0 +1,28 @@ | |||
| class ServiceAnsiblePlaybook < Service | |||
There was a problem hiding this comment.
ServiceAnsiblePlaybook < ServiceGeneric
app/models/service_generic.rb
Outdated
| @@ -1,31 +1,31 @@ | |||
| class ServiceGeneric < Service | |||
| # A chance for taking options from automate script to override options from a service dialog | |||
| def preprovision(_options = {}) | |||
| def preprocess(service_context) | |||
There was a problem hiding this comment.
def preprocess(action, options = {})
| @@ -0,0 +1,10 @@ | |||
| module MiqAeMethodService | |||
| class MiqAeServiceServiceAnsiblePlaybook < MiqAeServiceService | |||
There was a problem hiding this comment.
expose these methods in MiqAeServiceServiceGeneric
There was a problem hiding this comment.
We can delete all the exposes here
tinaafitz
force-pushed
the
ansible_playbook_statemachine_related_changes
branch
2 times, most recently
from
9ff4c77
to
99a07e5
Compare
bzwei
reviewed
Feb 1, 2017
app/models/service_generic.rb
Outdated
| @@ -1,31 +1,31 @@ | |||
| class ServiceGeneric < Service | |||
| # A chance for taking options from automate script to override options from a service dialog | |||
| def preprovision(_options = {}) | |||
| def preprocess(action, options = {}) | |||
| end | |||
|
|
|||
| # Interact with external provider to act on this service item | |||
tinaafitz
force-pushed
the
ansible_playbook_statemachine_related_changes
branch
from
99a07e5
to
1ccd6e7
Compare
bzwei
reviewed
Feb 2, 2017
app/models/service_generic.rb
Outdated
| end | ||
|
|
||
| # Interact with external provider to act on this service item | ||
| # The result is called stack, normally a vmdb object. It can map to an object in the provider, |
There was a problem hiding this comment.
Remove this line "# The result is called stack ..."
tinaafitz
force-pushed
the
ansible_playbook_statemachine_related_changes
branch
from
1ccd6e7
to
699537b
Compare
tinaafitz
changed the title
bzwei
approved these changes
Feb 2, 2017
|
@gmcculloug please review and merge |
|
@tinaafitz I see you removed '[WIP]' from the title, but not the label. Also, can you address the rubocop issues before merging. |
Related Automate model changes. ManageIQ/manageiq-content#24
tinaafitz
force-pushed
the
ansible_playbook_statemachine_related_changes
branch
from
699537b
to
869f21d
Compare
|
Checked commit tinaafitz@869f21d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added service model for ansible playbook and expose new methods.
Added initial methods for ansible playbook.
Modified generic service for method name changes
Related Automate model changes.
ManageIQ/manageiq-content#24