Container managers #connect: don't mutate argument

[cben]

Didn't cause any bugs that I know of, but safer not to do it.
@yaacov Please review

[simon3z]

Since we're touching the values here below anyway, you can actually do:

sanitized_options = options.merge({
  :hostname => options[:hostname] || address,
  :port     => options[:port] || port,
  ...
})

[simon3z]

@cben what about other providers?

[simon3z]

LGTM 👍
cc @blomquisg ready for review/merge

@miq-bot assign blomquisg

[cben]

@cben what about other providers?

Openshift inherits connect from here.
No idea what other providers do, don't think there is correlation. Sampled now couple random ones and those were fine.

Travis failure is unrelated new brakeman (kbrock has a PR for that).

[simon3z]

@cben I think this part affects the behavior of the "Validate" button in the UI when you're in the process of adding a new provider. Did you check that everything is OK there?

[cben]

Interesting (and troubling if so), didn't, will check.

[simon3z]

Travis failing and a pending question on @cben

@miq-bot assign cben

[miq-bot]

Checked commit cben@722ab81 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 👍

[yaacov]

LGTM 👍

[cben]

I think this part affects the behavior of the "Validate" button in the UI when you're in the process of adding a new provider. Did you check that everything is OK there?

@simon3z New provider: main [Validate] works, hawkular [Validate] works, [Add] works.
After creation: auth good, hawkular auth good, refresh works.
Edit: main [Validate] works, hawkular [Validate] works, [Save] works. Auth & refresh still work.

Travis failure was unrelated brakeman, good after rebase.

@miq-bot assign blomquisg