Add snapshotting for instances in the API #13729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abellotti
reviewed
Feb 1, 2017
| @@ -595,6 +595,7 @@ | |||
| - :collection | |||
| :subcollections: | |||
| - :load_balancers | |||
| - :snapshots | |||
There was a problem hiding this comment.
didn't see any identifiers specific to this, are both vms and instances using vm_snapshot_* ?
imtayadeway
changed the title
imtayadeway
force-pushed
the
api/snapshot-instances
branch
from
a0c913d
to
8c2b3f1
Compare
imtayadeway
changed the title
|
@miq-bot rm-label wip @abellotti newly rebased 😄 |
|
Checked commit imtayadeway@8c2b3f1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
abellotti
reviewed
Feb 8, 2017
| :identifier: cloud_volume_snapshot_delete | ||
| :delete: | ||
| - :name: delete | ||
| :identifier: cloud_volume_snapshot_delete |
There was a problem hiding this comment.
Nice!! Leveraging the new subcollection resource specific identifiers 👍
|
LGTM!! 🎵 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://bugzilla.redhat.com/show_bug.cgi?id=1399526