Resource action - Add service_action. #13751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinaafitz
force-pushed
the
add_service_action
branch
from
34f6217
to
4c293b4
Compare
|
@mkanoor Please review. |
|
Checked commit tinaafitz@4c293b4 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
mkanoor
reviewed
Feb 3, 2017
app/models/service_template.rb
Outdated
| build_options = {:action => action[:name], :fqname => fqname} | ||
| build_options = {:action => action[:name], | ||
| :fqname => fqname, | ||
| :ae_attributes => {:service_action => action[:name].downcase}} |
There was a problem hiding this comment.
@tinaafitz Should this be a symbol or a string, Would the engine convert it to a string if its a symbol
Converts every symbol to a string when it converts it into a URL
mkanoor
approved these changes
Feb 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resource action service_action value is needed by the Generic Service state machine for Ansible Playbook processing.
Related change:
ManageIQ/manageiq-ui-classic#297