Use task queue for VM actions

[sseago]

Uses task queue instead of making direct provider API calls from the UI.
The following model actions are affected:
resize
evacuate
associate_floating_ip
disassociate_floating_ip

This commit contains the necessary model changes.

[miq-bot]

Checked commit sseago@e425566 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 1 offense detected

app/models/manageiq/providers/cloud_manager/vm.rb

• ❗ - Line 129, Col 72 - Style/TrailingWhitespace - Trailing whitespace detected.

[tzumainn]

Looks good! Two quick questions:

a) the other *_queue methods in vm.rb are class methods - do you know if it's appropriate for these to be the same?

b) will there be a follow up PR against the UI that updates their calls to use the _queue methods? It looks like the UI will still be functional in the meantime, even if this is merged, correct?

[sseago]

@tzumainn
Regarding your questions:
a) At least for the _queue methods I created, since the _queue method is a stand-in for the direct method, whether it's a class method or not depends on whether the direct method is a class method. The queuing operation works for both class and instance methods, so it works either way.

b) For all of the calls I've converted, the UI PR should be referencing only the _queue methods now. Did I miss any? If there are other UI actions that still make direct calls instead of _queue ones, we should fix those too. If they relate to these particular new _queue calls, they probably belong in the associated UI PR for this -- if they're remnant direct calls for methods previously converted to using task queues, then a separate PR is probably better.

[tzumainn]

@sseago Gotcha; I missed the UI PR, but all looks to be in order there. Thanks!

👍 from me - @blomquisg, any concerns?