Chargeback without C & U #13884
Merged
Chargeback without C & U #13884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpichler
force-pushed
the
chargeback_without_c_and_u
branch
from
e7dd808
to
5f9a15f
Compare
|
This pull request is not mergeable. Please rebase and repush. |
lpichler
force-pushed
the
chargeback_without_c_and_u
branch
from
5f9a15f
to
2423168
Compare
|
This pull request is not mergeable. Please rebase and repush. |
gtanzillo
approved these changes
Feb 15, 2017
lpichler
force-pushed
the
chargeback_without_c_and_u
branch
from
2423168
to
06ac284
Compare
lpichler
force-pushed
the
chargeback_without_c_and_u
branch
from
06ac284
to
fd4e5e8
Compare
|
per discussion with @gtanzillo I flip semantic in option for this feature, from conflicts resolved 👍 |
@options[:include_metrics] is on the report means nil - (default) include metrics rollups true - include metric rollups false - don't include metric rollups this covering methond include_metrics? which is returning false or true
when ReportOptions#include_metrics? is false
(without alignment of code)
lpichler
force-pushed
the
chargeback_without_c_and_u
branch
from
fd4e5e8
to
939fd8f
Compare
|
Checked commits lpichler/manageiq@529bda8~...939fd8f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 spec/models/chargeback_vm_spec.rb
|
kbrock
reviewed
Feb 16, 2017
| # support hyper-v for which we do not collect metrics yet | ||
| scope = ManageIQ::Providers::Microsoft::InfraManager::Vm | ||
| # support hyper-v for which we do not collect metrics yet (also when we are including metrics in calculations) | ||
| scope = @options.include_metrics? ? ManageIQ::Providers::Microsoft::InfraManager::Vm : vms |
There was a problem hiding this comment.
aside: we need to get this class reference out of here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@options[:include_metrics]on the report meansnil- (default) include metrics rollupstrue- include metric rollupsfalse- don't include metric rollupsthis covering method
include_metrics?which is returning only false or true
Avoid charging resources with metric rollups
when
options.include_metrics?is falseI am sorry for commit
I separate testing chargeback by metric with/without rollups by
context.I need to have clean setup for testing chargeback without any created VMs
So in the commit is just aligning code by 2 spaces after separation in commit
@miq-bot assign @gtanzillo
@miq-bot add_label chargeback, enhancement
please review @isimluk