Expose job_template from a service template #13895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bzwei @gmcculloug |
bzwei
reviewed
Feb 13, 2017
| @@ -7,6 +7,11 @@ def self.default_retirement_entry_point | |||
| '/Service/Generic/StateMachines/GenericLifecycle/retire' | |||
| end | |||
|
|
|||
| def job_template(service_action) | |||
There was a problem hiding this comment.
You can use find_by as shown https://github.com/ManageIQ/manageiq/blob/master/app/models/service_ansible_playbook.rb#L41
And you can change ServiceAnsiblePlaybook to delegate this method through the service template.
|
@bzwei @gmcculloug |
For ServiceTemplateAnsiblePlaybook expose the job_template associated with a service action
mkanoor
force-pushed
the
ansible_factory
branch
from
767873b
to
59ec117
Compare
|
Checked commits mkanoor/manageiq@91aeff7~...59ec117 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
bzwei
approved these changes
Feb 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automate methods need to get to the credentials from a service template.
The ServiceTemplateAnsiblePlaybook exposes the job_template method.
Given a job_template we can get to the manager and from the manager get the credentials.
Will add specs later once the spec file changes have been finalized from PR #13736
Links