Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Run Ansible Playbook control action type #13943

Merged
merged 1 commit into from
Feb 16, 2017

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Feb 16, 2017

Add Run Ansible Playbook control action type

Links

@lgalis
Copy link
Contributor Author

lgalis commented Feb 16, 2017

@miq-bot assign @gmcculloug

@miq-bot
Copy link
Member

miq-bot commented Feb 16, 2017

@lgalis Cannot apply the following label because they are not recognized: automation/ansible tower

@lgalis
Copy link
Contributor Author

lgalis commented Feb 16, 2017

@miq-bot add_label enhancement

@miq-bot
Copy link
Member

miq-bot commented Feb 16, 2017

@lgalis Cannot apply the following label because they are not recognized: automation/ansible tower

@lgalis
Copy link
Contributor Author

lgalis commented Feb 16, 2017

@miq-bot add_label automation/ansible_tower

@miq-bot
Copy link
Member

miq-bot commented Feb 16, 2017

@lgalis Cannot apply the following label because they are not recognized: automation/ansible_tower

@@ -20,7 +20,8 @@ class MiqAction < ApplicationRecord
"set_custom_attribute" => "Set a Custom Attribute in vCenter",
"inherit_parent_tags" => "Inherit Parent Tags",
"remove_tags" => "Remove Tags",
"delete_snapshots_by_age" => "Delete Snapshots by Age"
"delete_snapshots_by_age" => "Delete Snapshots by Age",
"run_an_ansible_playbook" => "Run an Ansible Playbook"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer "run_ansible_playbook" => "Run Ansible Playbook"

@lgalis lgalis force-pushed the add_ansible_playbook_action_type branch from 5531c75 to a79fcaf Compare February 16, 2017 16:36
@miq-bot
Copy link
Member

miq-bot commented Feb 16, 2017

Checked commit lgalis@a79fcaf with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🏆

@lgalis
Copy link
Contributor Author

lgalis commented Feb 16, 2017

/cc @mkanoor - note the change in the action name

@gmcculloug gmcculloug merged commit e64c813 into ManageIQ:master Feb 16, 2017
@gmcculloug gmcculloug added this to the Sprint 55 Ending Feb 27, 2017 milestone Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants