Add service object to deliver to automate. #13956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generic service state machine uses the service object. We're currently getting the service object from the task which causes a problem in retirement because we don't have a task.
tinaafitz
force-pushed
the
add_service_object_to_deliver
branch
from
126731c
to
8cd6d8f
Compare
|
@mkanoor Please review. |
|
Checked commit tinaafitz@8cd6d8f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
👍 |
|
@gmcculloug Please Review |
gmcculloug
reviewed
Feb 20, 2017
| @@ -86,7 +88,7 @@ def service_resource_id(index, scaling_max) | |||
| :class_name => 'ServiceProvision_Template', | |||
| :instance_name => 'clone_to_service', | |||
| :automate_message => 'create', | |||
| :attrs => {'request' => 'clone_to_service'}, | |||
| :attrs => {'request' => 'clone_to_service', 'Service::Service' => @service.id}, | |||
There was a problem hiding this comment.
@mkanoor I thought the variable name was lower cased. I would expect this to be 'Service::service' => @service.id.
There was a problem hiding this comment.
@gmcculloug Discussed this with @mkanoor. No need to down case the variable name since attributes are down cased in the engine:
https://github.com/tinaafitz/manageiq/blob/master/lib/miq_automation_engine/engine/miq_ae_object.rb#L277
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic service state machine uses the service object.
We're currently getting the service object from the task which causes a
problem in retirement because we don't have a task.