Remove the mechanisms around "configuring" central admin #13966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was put in place because the authentication method we were using involved encrypting a token using a remote region's v2_key. The initial assumption was that regions could have different keys so we needed to do some configuration to fetch the remote key for each subscription. That assumption has been proven incorrect; all regions in the enterprise should be using the same v2_key. This allows us to authenticate with remote regions as soon as replication is configured.
|
Keeping this WIP until the UI side is merged. I don't imagine much change here though so feel free to review 😄 |
|
Do you need a data migration to remove the offending auth records? |
|
@Fryguy Yup, forgot about that, thanks for remembering 😄 |
The AuthenticationMixin was added to MiqRegion specifically for saving these records. Because of this we can just remove all the authentication records that point to an MiqRegion resource.
|
Checked commits carbonin/manageiq@96d528c~...37f854e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
carbonin
changed the title
|
Th UI PR was merged so this is ready to go. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was put in place because the authentication method we were using involved encrypting a token using a remote region's v2_key.
The initial assumption was that regions could have different keys so we needed to do some configuration to fetch the remote key for each subscription.
That assumption has been proven incorrect; all regions in the enterprise should be using the same v2_key. This allows us to authenticate with remote regions as soon as replication is configured.
Related UI PR ManageIQ/manageiq-ui-classic#421