Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing authentication require_nested #14018

Merged
merged 1 commit into from
Feb 22, 2017

Conversation

durandom
Copy link
Member

otherwise we encounter the dreaded

warning: toplevel constant Authentication referenced by ManageIQ::Providers::AutomationManager::Authentication

warning

@miq-bot add_labels bug, providers/ansible_tower
@miq-bot assign @agrare

@miq-bot
Copy link
Member

miq-bot commented Feb 22, 2017

Checked commit durandom@4fda804 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. ⭐

@agrare
Copy link
Member

agrare commented Feb 22, 2017

👍

@agrare
Copy link
Member

agrare commented Feb 22, 2017

That's weird the test passed a while ago but still says it is in progress here

@agrare
Copy link
Member

agrare commented Feb 22, 2017

Going to merge, the test clearly passed

@agrare agrare merged commit 36b4ae7 into ManageIQ:master Feb 22, 2017
@agrare agrare added this to the Sprint 55 Ending Feb 27, 2017 milestone Feb 22, 2017
@agrare agrare added the euwe/no label Feb 22, 2017
@durandom durandom deleted the ansible_automation_manager branch February 22, 2017 14:36
@durandom
Copy link
Member Author

cool, travis seems to have hickups today...

@agrare
Copy link
Member

agrare commented Feb 22, 2017

Hopefully those hiccups don't include saying a test is green when it is really still in progress 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants