Enable cloud_tenant based RBAC for additional models #14036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwsu
force-pushed
the
cloud-tenant-rbac
branch
from
d3c2605
to
bd1e24b
Compare
rwsu
changed the title
rwsu
force-pushed
the
cloud-tenant-rbac
branch
from
8359a2a
to
e471dbb
Compare
rwsu
changed the title
rwsu
force-pushed
the
cloud-tenant-rbac
branch
3 times, most recently
from
41e394d
to
2385dda
Compare
|
This pull request is not mergeable. Please rebase and repush. |
Adds CloudTenancyMixin to CloudNetwork CloudObjectStoreContainer CloudObjectStoreObject CloudSubnet CloudTenant CloudVolumeSnapshot Flavor FloatingIp LoadBalancer NetworkPort NetworkRouter SecurityGroup Modified OpenStack CloudManager to also update the network provider's tenant_mapping_enabled value.
|
@rwsu Can you add specs for CloudTenant and Flavor, please ? |
CloudTenant and Flavor have specialized tenant_joins_clauses that warrant additional tests.
|
Checked commits rwsu/manageiq@3bf5b01~...a3f8cba with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@lpichler, specs added for CloudTenant and Flavor. |
|
@gtanzillo, can you review? I think @lpichler might be ooto. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes RBAC for select cloud_tenant based models when tenant_mapping_enabled is turned on. Previously, anyone can see any tenant's objects. The fix adds CloudTenancyMixin to a model which in turn causes the correct AR joins and where clauses to be generated during tenant scoping in Filterer.search.
This patch adds CloudTenancyMixin to
CloudNetwork
CloudObjectStoreContainer
CloudObjectStoreObject
CloudSubnet
CloudTenant
CloudVolumeSnapshot
Flavor
FloatingIp
LoadBalancer
NetworkPort
NetworkRouter
SecurityGroup
Modified OpenStack CloudManager to also update the network
provider's tenant_mapping_enabled value.
Depends on #13535
Steps for Testing/QA