Allow create_in_provider to fail #14049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bzwei Please review |
bzwei
approved these changes
Feb 23, 2017
|
@bdunne Please add a test. |
bdunne
force-pushed
the
api_create_failures
branch
from
9f1b128
to
6b6fb75
Compare
Credentials should already be valid at this point, if not, that is the problem of the refresh. We should raise an error if the record is not found in our database
|
This pull request is not mergeable. Please rebase and repush. |
bdunne
force-pushed
the
api_create_failures
branch
from
6b6fb75
to
affb2af
Compare
|
Checked commit bdunne@affb2af with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credentials should already be valid at this point, if not, that is the
problem of the refresh.
We should raise an error if the record is not found in our database
Without the
find_by!, the method returns nil and code will blow up later in the process making it hard to figure out what went wrong.