Enterprise rate parent for containers chargeback #14079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeari
force-pushed
the
enterprize_rate_parent
branch
3 times, most recently
from
267432b
to
920be37
Compare
|
Checked commit zeari@920be37 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@miq-bot add_label providers/containers, chargeback |
|
@Loicavenel we'll have to know if this is a valid use case (:+1: from me, it makes sense). If so we'll need a BZ (cc @zeari), and @epacific1 will have to add this to the test cases matrix. |
|
yes, it make senses. |
simaishi
pushed a commit
that referenced
this pull request
Mar 8, 2017
Enterprise rate parent for containers chargeback (cherry picked from commit 0b91241) https://bugzilla.redhat.com/show_bug.cgi?id=1428900
|
Euwe backport details: |
|
@zeari Travis is failing in Euwe (https://travis-ci.org/ManageIQ/manageiq/jobs/209089734). I think it's caused by backporting this PR without #13858. Can you create an Euwe PR to fix the test? |
simaishi
added a commit
that referenced
this pull request
Mar 9, 2017
[EUWE] Fix failing specs on euwe following #14079
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding enterprise as a rate parent in
ChargebackContainerProject. This means rates that are assigned to enterprise would act the same as rates assigned to Containers Providers for this particular chargeback type.Im hesitant to add the same for
ChargebackContainerImage. that would need more of a discussion on why and how rates should be inherited for that use case.@simon3z
cc @blomquisg @gtanzillo