Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove admin role for tenant admin #14081

Merged

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Feb 27, 2017

Follow up: #13689

https://bugzilla.redhat.com/show_bug.cgi?id=1426619

User with tenant-admin role cannot user administator-role(cannot see or assign it to any group).
Other roles have lower permissions.

@miq-bot add_label rbac, core, enhancement, euwe/yes

@miq-bot assign @gtanzillo

this role also has higher permission then
tenant-administator-role - no other roles
@miq-bot
Copy link
Member

miq-bot commented Feb 27, 2017

Checked commits lpichler/manageiq@788f6ae~...4fc245a with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. ⭐

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@gtanzillo gtanzillo added this to the Sprint 55 Ending Feb 27, 2017 milestone Feb 27, 2017
@gtanzillo gtanzillo merged commit 8036eda into ManageIQ:master Feb 27, 2017
@lpichler lpichler deleted the remove_admin_role_for_tenant_admin branch February 28, 2017 16:09
@lpichler
Copy link
Contributor Author

lpichler commented Mar 3, 2017

simaishi pushed a commit that referenced this pull request Mar 8, 2017
@simaishi
Copy link
Contributor

simaishi commented Mar 8, 2017

Euwe backport details:

$ git log -1
commit 4b43ce246836e83f61312775b8a934c5b946a43c
Author: Gregg Tanzillo <[email protected]>
Date:   Mon Feb 27 17:14:32 2017 -0500

    Merge pull request #14081 from lpichler/remove_admin_role_for_tenant_admin
    
    Remove admin role for tenant admin
    (cherry picked from commit 8036eda9632d64d635401ef6c1a747e9e1ee084c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1428131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants