Fix fetch methods in services controller #14087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit jntullo@be5b23e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Nice find @jntullo 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking into #13664, I noticed that there were no tests for referencing objects via
idorhrefon services create, and that it wasn't working as expected. Parsing byidworked buthrefparsing did not work because it was not specifying the correct collection::serviceneeded to be:services:orchestration_templateneeded to be:orchestration_templates:orchestration_managerneeded to be:providersThis fixes the above issues and also adds in appropriate tests.
@miq-bot add_label bug, api, test
@miq-bot assign @abellotti
(this is also my 💯 manageiq PR! 🎉 )