Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add oVirt cloud-init customization template #14139

Merged
merged 1 commit into from
Mar 17, 2017
Merged

Add oVirt cloud-init customization template #14139

merged 1 commit into from
Mar 17, 2017

Conversation

jhernand
Copy link
Contributor

@jhernand jhernand commented Mar 2, 2017

Currently ManageIQ doesn't include a customization template that can be used
out of the box to set the host name, root password and IP address in oVirt,
using cloud-init. This patch adds it.

https://bugzilla.redhat.com/1427603

@jhernand
Add oVirt cloud-init customization template
aee6410 
Currently ManageIQ doesn't include a customization template that can be used
out of the box to set the host name, root password and IP address in oVirt,
using cloud-init. This patch adds it.

https://bugzilla.redhat.com/1427603
@jhernand
Copy link
Contributor Author

jhernand commented Mar 2, 2017

@miq-bot assign @oourfali

@jhernand
Copy link
Contributor Author

jhernand commented Mar 2, 2017

@borod108 @masayag @durandom please review.

@miq-bot
Copy link
Member

miq-bot commented Mar 2, 2017

Checked commit https://github.com/jhernand/manageiq/commit/aee64100f9089caa582c8bd405d4fdc517c3c2c6 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 🍰

@jhernand
Copy link
Contributor Author

jhernand commented Mar 2, 2017

Bug 1427603 - No payload sent to rhevm4.0 from cfme-5.7.0

durandom
durandom approved these changes Mar 3, 2017
View reviewed changes
Copy link
Member

@durandom durandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I have 0️⃣ knowledge about those templates, @agrare judging by git blame it was mostly @bdunne and @Fryguy adding stuff here.

You know of somebody else who could take a look?

db/fixtures/customization_templates.yml

- :name: oVirt cloud-init
:description: This template generates the cloud-init configuration supported by oVirt
:script: |-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 for using the block syntax

@durandom
Copy link
Member

durandom commented Mar 3, 2017

euwe/no bc the BZ is for cfme-future

@miq-bot add_labels euwe/no, bug, providers/rhevm

@durandom
Copy link
Member

@miq-bot assign @agrare

@agrare do you know who can help to review this?

@miq-bot miq-bot assigned agrare and unassigned oourfali Mar 14, 2017
@agrare
Copy link
Member

agrare commented Mar 15, 2017

@durandom either @gmcculloug or @bdunne would be best.

@agrare agrare assigned gmcculloug and unassigned agrare Mar 15, 2017
@bdunne bdunne merged commit 1029890 into ManageIQ:master Mar 17, 2017
@bdunne bdunne added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 17, 2017
@chessbyte chessbyte assigned bdunne and unassigned gmcculloug Mar 17, 2017
@oourfali
Copy link

@bdunne The bug was cloned.
The euwe bug is https://bugzilla.redhat.com/1417757

@miq-bot add_labels euwe/yes

@bdunne bdunne removed the euwe/no label Mar 20, 2017
simaishi pushed a commit that referenced this pull request Mar 21, 2017
@bdunne @simaishi
Merge pull request #14139 from jhernand/add_ovirt_cloud_init_customiz…
3852c83 
…ation_template

Add oVirt cloud-init customization template
(cherry picked from commit 1029890)

https://bugzilla.redhat.com/show_bug.cgi?id=1434428
@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit 3852c837ebe5ce56f649737ee0b71252f2cd5741
Author: Brandon Dunne <[email protected]>
Date:   Fri Mar 17 13:28:28 2017 -0400

    Merge pull request #14139 from jhernand/add_ovirt_cloud_init_customization_template
    
    Add oVirt cloud-init customization template
    (cherry picked from commit 1029890136014d5e35d8715d0b41f92292068552)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1434428

@simaishi simaishi removed the euwe/yes label Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durandom durandom durandom approved these changes

@bdunne bdunne bdunne approved these changes

@gmcculloug gmcculloug Awaiting requested review from gmcculloug

Assignees

@bdunne bdunne

Labels
enhancement euwe/backported providers/infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jhernand @miq-bot @durandom @agrare @oourfali @simaishi @bdunne @Fryguy @gmcculloug