Always pass the URL path to the oVirt SDK #14159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the 'path' component of the URL is not always explicitly passed to the constructor of the oVirt SDK connection, it is only passed if explicitly provided by the caller. This patch changes the oVirt provider so that the path is always passed, taking it from the endpoint table if not explicitly provided by the caller. Signed-off-by: Juan Hernandez <[email protected]>
|
@borod108 @pkliczewski please review. |
|
Checked commit https://github.com/jhernand/manageiq/commit/15c965f5d83828189d59d041fc95a325efa1a7b6 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
pkliczewski
approved these changes
Mar 3, 2017
|
@durandom please review. |
|
@oourfali the change in this PR looks trivial. Please give your 👍 so we can merge. |
|
I see @pkliczewski approved, so we can proceed with this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the 'path' component of the URL is not always explicitly
passed to the constructor of the oVirt SDK connection, it is only passed
if explicitly provided by the caller. This patch changes the oVirt
provider so that the path is always passed, taking it from the endpoint
table if not explicitly provided by the caller.