Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EmbeddedAnsible workers to WorkerManagement #14234

Merged

Conversation

blomquisg
Copy link
Member

EmbeddedAnsible workers need to exist in WorkerManagement::ClassNames so that workers can be controlled by Worker Management.

@carbonin
Copy link
Member

carbonin commented Mar 8, 2017

It seems like we also need keys for these workers in config/settings.yml

@blomquisg
Copy link
Member Author

It seems like we also need keys for these workers in config/settings.yml

ACK

@blomquisg
Copy link
Member Author

That that, Travis!

@miq-bot
Copy link
Member

miq-bot commented Mar 8, 2017

Checked commits blomquisg/manageiq@98b5dd8~...36d4c97 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. ⭐

@gmcculloug
Copy link
Member

👍 My second favorite PR of the day. Since I do not have any silver medals you get this: 🏅

@gmcculloug gmcculloug merged commit 869b81a into ManageIQ:master Mar 8, 2017
@gmcculloug gmcculloug added this to the Sprint 56 Ending Mar 13, 2017 milestone Mar 8, 2017
@blomquisg blomquisg deleted the embedded_ansible_worker_class_names branch November 28, 2017 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants