Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove body param from MiqAeService as it's not used #14276

Merged
merged 1 commit into from
Mar 12, 2017
Merged

Remove body param from MiqAeService as it's not used #14276

merged 1 commit into from
Mar 12, 2017

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Mar 10, 2017

Follow on from #14239

@miq-bot
Copy link
Member

miq-bot commented Mar 10, 2017

Checked commit Fryguy@ff31d8a with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. ⭐

@Fryguy
Copy link
Member Author

Fryguy commented Mar 10, 2017

cc @jrafanie

jrafanie
jrafanie approved these changes Mar 10, 2017
View reviewed changes
Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it passes

@mkanoor
Copy link
Contributor

mkanoor commented Mar 10, 2017

👍

@jrafanie jrafanie added this to the Sprint 56 Ending Mar 13, 2017 milestone Mar 12, 2017
@jrafanie jrafanie merged commit bfad747 into ManageIQ:master Mar 12, 2017
@jrafanie jrafanie assigned jrafanie and unassigned mkanoor Mar 12, 2017
@Fryguy Fryguy deleted the remove_body_param_from_miq_ae_service branch March 16, 2017 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrafanie jrafanie jrafanie approved these changes

Assignees

@jrafanie jrafanie

Labels
automate technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fryguy @miq-bot @mkanoor @jrafanie