Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiqApache::Conf.create_balancer_config expects a :lbmethod key #14306

Merged
merged 1 commit into from
Mar 14, 2017

Conversation

carbonin
Copy link
Member

This will allow us to pick methods other than byrequests, which was the default in MiqApache::Conf

…ethod

This will allow us to pick methods other than byrequests, which was the
default in MiqApache::Conf
@carbonin
Copy link
Member Author

For reference MiqApache::Conf.create_balancer_config

@miq-bot
Copy link
Member

miq-bot commented Mar 13, 2017

Checked commit carbonin@7f537bb with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🏆

@jrafanie
Copy link
Member

LGTM, this would fix the bybusyness of each worker not being accepted.

For future me, this is the commit that broke it:

commit d0aacdfa98160040958d8ddfdc98c5a56122ec56
Author: REDACTED
Date:   Wed Sep 18 11:34:10 2013 -0400

    Modify constants for two different files, pass filenames in options hash

@Fryguy
Copy link
Member

Fryguy commented Mar 14, 2017

@jrafanie If you approve it that much why not just merge it? 🤣

@jrafanie
Copy link
Member

Fine, I was caught up in the ability to approve something I already approved. 😜

@jrafanie jrafanie merged commit a94622d into ManageIQ:master Mar 14, 2017
@jrafanie
Copy link
Member

@carbonin Should this be euwe/yes? We'd expect to use bybusyness but we're using byrequests because of this bug.

@jrafanie jrafanie added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 14, 2017
@carbonin
Copy link
Member Author

Sure, I labeled it no because we didn't have a specific BZ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants