Add balancer members after configs have been written #14311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugzilla.redhat.com/show_bug.cgi?id=1422988 Fixes a regression in ManageIQ#14007 that affects the initial start of the appliance which caused a 503 error when trying to access the UI. Because adding balancer members does a validation of the configuration files and these files try to load the redirect files among others, we need to add the balancers members after all configuration files have been written by install_apache_proxy_config.
|
cc @fbladilo (hopefully this fixes your container builds) |
|
Checked commit jrafanie@a1ad99f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
jrafanie
added a commit
to jrafanie/manageiq-gems-pending
that referenced
this pull request
Mar 13, 2017
Related to ManageIQ/manageiq#14311 Previously, we quietly logged no result and lost the details of the exception. Now, we log the exception and any result if any... Before: [----] W, [2017-03-13T17:45:37.678276 #2555:b6b14c] WARN -- : MIQ(MiqApache::Control.config_ok?) Configuration syntax failed with error: [----] W, [2017-03-13T17:45:37.678401 #2555:b6b14c] WARN -- : MIQ(MiqApache::Conf.save) Restoring old configuration due to bad configuration! After: [----] W, [2017-03-13T17:45:37.678276 #2555:b6b14c] WARN -- : MIQ(MiqApache::Control.config_ok?) Configuration syntax failed with error: httpd: Syntax error on line 353 of /etc/httpd/conf/httpd.conf: Syntax error on line 12 of /etc/httpd/conf.d/manageiq-https-application.conf: Could not open configuration file /etc/httpd/conf.d/manageiq-redirects-websocket: No such file or directory for result: [----] W, [2017-03-13T17:45:37.678401 #2555:b6b14c] WARN -- : MIQ(MiqApache::Conf.save) Restoring old configuration due to bad configuration!
simaishi
pushed a commit
that referenced
this pull request
Mar 15, 2017
…l_configs_written Add balancer members after configs have been written (cherry picked from commit 5b167ab) https://bugzilla.redhat.com/show_bug.cgi?id=1432463
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression in #14007 that affects the initial start of the
appliance which caused a 503 error when trying to access the UI.
https://bugzilla.redhat.com/show_bug.cgi?id=1422988
Because adding balancer members does a validation of the configuration
files and these files try to load the redirect files among others,
we need to add the balancers members after all configuration files have
been written by install_apache_proxy_config.
I wish I knew how to test this outside of an appliance. ❓