Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mixed values in Low and High operating ranges for CU charts #14324

Merged
merged 1 commit into from
Mar 15, 2017

Conversation

PanSpagetka
Copy link
Contributor

@PanSpagetka PanSpagetka commented Mar 14, 2017

There were mix indexes in these reports. col_order and headers has different number of fields. I find that the extra one is All Non-VM Files. Its possible that All Non-VM Files should be there and in col_order is missing related field. But i didnt find any related code to All Non-VM Files so i deleted it.

https://bugzilla.redhat.com/show_bug.cgi?id=1305115

Screenshots

Before:
screencapture-localhost-3000-vm_infra-explorer-1489497298972

After:
screencapture-localhost-3000-vm_infra-explorer-1489497371497

Links [Optional]

https://bugzilla.redhat.com/show_bug.cgi?id=1305115

@miq-bot
Copy link
Member

miq-bot commented Mar 14, 2017

Checked commit PanSpagetka@97d6a2d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 🍪

Copy link
Member

@isimluk isimluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great find!

@isimluk isimluk added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 15, 2017
@isimluk isimluk merged commit b3574a3 into ManageIQ:master Mar 15, 2017
simaishi pushed a commit that referenced this pull request Mar 16, 2017
Fix mixed values in Low and High operating ranges for CU charts
(cherry picked from commit b3574a3)

https://bugzilla.redhat.com/show_bug.cgi?id=1433093
@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit fa2a50eef3bf00307f6f4d3415c751eb38702800
Author: Šimon Lukašík <[email protected]>
Date:   Wed Mar 15 10:51:35 2017 +0100

    Merge pull request #14324 from PanSpagetka/fix-low-high-operating-range
    
    Fix mixed values in Low and High operating ranges for CU charts
    (cherry picked from commit b3574a3b4414818026b3b26e715fb76b95e72fba)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1433093

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants