Delete archived entities when a container manager is deleted #14359

zeari · 2017-03-16T13:46:03Z

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1458552
Delete archived entities of a container manager when the ems is deleted. This causes various errors in reports that deal with archived entities

@moolitayer @enoodle Please review
cc @simon3z

@miq-bot add_label providers/containers, bug

enoodle · 2017-03-16T15:27:47Z

app/models/manageiq/providers/container_manager.rb

@@ -22,6 +22,12 @@ class ContainerManager < BaseManager
    has_one :container_deployment, :foreign_key => :deployed_ems_id, :inverse_of => :deployed_ems
    has_many :computer_systems, :through => :container_nodes

+    # Archived entities to destroy when the container manager is deleted
+    has_many :old_container_groups, :foreign_key => :old_ems_id, :dependent => :destroy


@zeari Maybe I am mistaken but it seems to me that you need to tell it the type of the class to use when it is not clear :class_name => "ContainerGroups"

@enoodle right

moolitayer · 2017-03-16T16:08:35Z

app/models/manageiq/providers/container_manager.rb

+    # Archived entities to destroy when the container manager is deleted
+    has_many :old_container_groups, :foreign_key => :old_ems_id, :dependent => :destroy
+    has_many :old_containers, :foreign_key => :old_ems_id
+    has_many :old_container_definitions, :foreign_key => :old_ems_id


Where are the two above needed if they have no dependent destroy?

@moolitayer destroying container_group that destroys container_definition that destroys container
I thought it was worth mentioning though

So this is for documentation purposes?

Also do think you need

container_group.rb ... has_many :old_container_definitions, :dependent => :destroy container_definition.rb ... has_many :old_containers, :dependent => :destroy ...

?

moolitayer · 2017-03-19T13:29:37Z

So after some offline discussion with @zeari we came to a conclusion we should remove

has_many :old_containers, :foreign_key => :old_ems_id
has_many :old_container_definitions, :foreign_key => :old_ems_id

As both those entities are removed through hierarchy. For example when a container definition is archived, it remains linked to it's container group (whether the container group is archived or not)
and when the provider is destroyed it will be destroyed as well

zeari · 2017-03-19T13:35:47Z

So after some offline discussion with @zeari we came to a conclusion we should remove

has_many :old_containers, :foreign_key => :old_ems_id
has_many :old_container_definitions, :foreign_key => :old_ems_id

Done

miq-bot · 2017-03-20T14:34:23Z

Checked commit zeari@c8ceb77 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 👍

zeari · 2017-04-12T13:54:32Z

ping @simon3z
Archived entities get "orphaned" when their provider is deleted

simon3z · 2017-05-12T12:50:16Z

LGTM 👍
@miq-bot add_label ewue/yes
@miq-bot add_label fine/yes

@miq-bot assign blomquisg

miq-bot · 2017-05-12T12:51:24Z

@simon3z Cannot apply the following label because they are not recognized: ewue/yes

simon3z · 2017-05-12T12:54:18Z

@miq-bot add_label euwe/yes

simaishi · 2017-06-02T13:55:39Z

@zeari Is there a BZ for this? Can you please create if it doesn't exist?

zeari · 2017-06-04T09:46:21Z

@simaishi https://bugzilla.redhat.com/show_bug.cgi?id=1458552

…delete Delete archived entities when a container manager is deleted (cherry picked from commit 48d0291) https://bugzilla.redhat.com/show_bug.cgi?id=1458811

simaishi · 2017-06-05T13:54:30Z

Euwe backport details:

$ git log -1
commit d7ed364c18d0f5f5498cc6d78458d128c586d383
Author: Oleg Barenboim <[email protected]>
Date:   Thu Jun 1 23:56:00 2017 -0400

    Merge pull request #14359 from zeari/delete_archived_entities_on_ems_delete
    
    Delete archived entities when a container manager is deleted
    (cherry picked from commit 48d0291098ab39b474cf4712d325d57260372fa0)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1458811

…delete Delete archived entities when a container manager is deleted (cherry picked from commit 48d0291) https://bugzilla.redhat.com/show_bug.cgi?id=1460397

simaishi · 2017-06-09T22:14:36Z

Fine backport details:

$ git log -1
commit a2cc7afe7426391b34016632aef4796e1526ba2a
Author: Oleg Barenboim <[email protected]>
Date:   Thu Jun 1 23:56:00 2017 -0400

    Merge pull request #14359 from zeari/delete_archived_entities_on_ems_delete
    
    Delete archived entities when a container manager is deleted
    (cherry picked from commit 48d0291098ab39b474cf4712d325d57260372fa0)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1460397

zeari changed the title ~~Delete archived entities on ems delete~~ Delete archived entities when a container manager is deleted Mar 16, 2017

zeari force-pushed the delete_archived_entities_on_ems_delete branch from 3001e82 to f520da0 Compare March 16, 2017 13:46

miq-bot added bug providers/containers labels Mar 16, 2017

zeari force-pushed the delete_archived_entities_on_ems_delete branch from f520da0 to 132148a Compare March 16, 2017 13:48

chessbyte assigned simon3z Mar 16, 2017

enoodle reviewed Mar 16, 2017

View reviewed changes

moolitayer reviewed Mar 16, 2017

View reviewed changes

zeari force-pushed the delete_archived_entities_on_ems_delete branch 2 times, most recently from 7a4754f to 8eabf4a Compare March 16, 2017 16:19

zeari force-pushed the delete_archived_entities_on_ems_delete branch from 8eabf4a to c8ceb77 Compare March 19, 2017 13:35

archived entitites of an ems should be destroyed with the ems

c8ceb77

simon3z approved these changes May 12, 2017

View reviewed changes

miq-bot added the fine/yes label May 12, 2017

miq-bot assigned blomquisg and unassigned simon3z May 12, 2017

miq-bot added the euwe/yes label May 12, 2017

chessbyte assigned chessbyte and unassigned blomquisg Jun 2, 2017

chessbyte merged commit 48d0291 into ManageIQ:master Jun 2, 2017

chessbyte added this to the Sprint 62 Ending Jun 5, 2017 milestone Jun 2, 2017

simaishi added the bugzilla needed label Jun 2, 2017

simaishi removed the bugzilla needed label Jun 5, 2017

simaishi added euwe/backported and removed euwe/yes labels Jun 5, 2017

simaishi added fine/backported and removed fine/yes labels Jun 9, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delete archived entities when a container manager is deleted #14359

Delete archived entities when a container manager is deleted #14359

zeari commented Mar 16, 2017 •

edited

Loading

enoodle Mar 16, 2017

zeari Mar 16, 2017

moolitayer Mar 16, 2017

zeari Mar 16, 2017 •

edited

Loading

moolitayer Mar 19, 2017

moolitayer commented Mar 19, 2017 •

edited

Loading

zeari commented Mar 19, 2017

miq-bot commented Mar 20, 2017

zeari commented Apr 12, 2017 •

edited

Loading

simon3z commented May 12, 2017

miq-bot commented May 12, 2017

simon3z commented May 12, 2017

simaishi commented Jun 2, 2017

zeari commented Jun 4, 2017

simaishi commented Jun 5, 2017

simaishi commented Jun 9, 2017

Delete archived entities when a container manager is deleted #14359

Delete archived entities when a container manager is deleted #14359

Conversation

zeari commented Mar 16, 2017 • edited Loading

enoodle Mar 16, 2017

Choose a reason for hiding this comment

zeari Mar 16, 2017

Choose a reason for hiding this comment

moolitayer Mar 16, 2017

Choose a reason for hiding this comment

zeari Mar 16, 2017 • edited Loading

Choose a reason for hiding this comment

moolitayer Mar 19, 2017

Choose a reason for hiding this comment

moolitayer commented Mar 19, 2017 • edited Loading

zeari commented Mar 19, 2017

miq-bot commented Mar 20, 2017

zeari commented Apr 12, 2017 • edited Loading

simon3z commented May 12, 2017

miq-bot commented May 12, 2017

simon3z commented May 12, 2017

simaishi commented Jun 2, 2017

zeari commented Jun 4, 2017

simaishi commented Jun 5, 2017

simaishi commented Jun 9, 2017

zeari commented Mar 16, 2017 •

edited

Loading

zeari Mar 16, 2017 •

edited

Loading

moolitayer commented Mar 19, 2017 •

edited

Loading

zeari commented Apr 12, 2017 •

edited

Loading