Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the logic to allow a policy to prevent request_vm_scan. #14370

Merged
merged 2 commits into from
Mar 17, 2017
Merged

Add the logic to allow a policy to prevent request_vm_scan. #14370

merged 2 commits into from
Mar 17, 2017

Conversation

lfu
Copy link
Member

@lfu lfu commented Mar 16, 2017

@gmcculloug
Copy link
Member

@lfu Please review test failures.

@lfu lfu force-pushed the prevent_request_vm_scan_1433084 branch from 711c016 to 15815e8 Compare March 17, 2017 12:25
@lfu lfu force-pushed the prevent_request_vm_scan_1433084 branch from 15815e8 to 0241aa9 Compare March 17, 2017 12:39
@lfu lfu force-pushed the prevent_request_vm_scan_1433084 branch from 0241aa9 to 89b85a7 Compare March 17, 2017 13:12
@miq-bot
Copy link
Member

miq-bot commented Mar 17, 2017

Some comments on commits lfu/manageiq@dc64ef6~...89b85a7

spec/models/vm_spec.rb

  • ⚠️ - 208 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
  • ⚠️ - 217 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
  • ⚠️ - 220 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

@miq-bot
Copy link
Member

miq-bot commented Mar 17, 2017

Checked commits lfu/manageiq@dc64ef6~...89b85a7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
8 files checked, 0 offenses detected
Everything looks good. 🏆

@gmcculloug
Copy link
Member

The functionality broke when the event_stream logic was introduced. At that time policy checks became async events and the inline call to MiqEvent.raise_evm_job_event no longer raised the error back to the caller.

Tested yesterday and validated it is working as expected now. 👍

@gmcculloug gmcculloug merged commit 83a1785 into ManageIQ:master Mar 17, 2017
@gmcculloug gmcculloug added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 17, 2017
simaishi pushed a commit that referenced this pull request Mar 17, 2017
@gmcculloug @simaishi
Merge pull request #14370 from lfu/prevent_request_vm_scan_1433084
22250ed 
Add the logic to allow a policy to prevent request_vm_scan.
(cherry picked from commit 83a1785)

https://bugzilla.redhat.com/show_bug.cgi?id=1433435
@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit 22250ed7e91811e580603f6b5bf9d045a6d7e429
Author: Greg McCullough <[email protected]>
Date:   Fri Mar 17 12:00:48 2017 -0400

    Merge pull request #14370 from lfu/prevent_request_vm_scan_1433084
    
    Add the logic to allow a policy to prevent request_vm_scan.
    (cherry picked from commit 83a1785facb87e8d108c1033b8591530b1bbfd18)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1433435

agrare pushed a commit to agrare/manageiq that referenced this pull request Apr 19, 2017
@gmcculloug @simaishi
Merge pull request ManageIQ#14370 from lfu/prevent_request_vm_scan_14…
9f3498c 
…33084

Add the logic to allow a policy to prevent request_vm_scan.
(cherry picked from commit 83a1785)

https://bugzilla.redhat.com/show_bug.cgi?id=1433435
(cherry picked from commit 22250ed)
@lfu lfu deleted the prevent_request_vm_scan_1433084 branch October 16, 2017 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmcculloug gmcculloug

Labels
bug core/policy core/smart state euwe/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lfu @gmcculloug @miq-bot @simaishi