Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable put/patch on configuration script sources and authentications #14381

Merged
merged 1 commit into from
Mar 17, 2017
Merged

Enable put/patch on configuration script sources and authentications #14381

merged 1 commit into from
Mar 17, 2017

Conversation

jntullo
Copy link

@jntullo jntullo commented Mar 17, 2017

@jntullo
Copy link
Author

jntullo commented Mar 17, 2017

@miq-bot add_label enhancement, api

@himdel
Copy link
Contributor

himdel commented Mar 17, 2017

Thanks! :) 👍

@abellotti
Copy link
Member

if we think PUT and PATCH type edits are coming in, let's add a test for each type for this collection just to make sure we don't regress later, Thanks.

@miq-bot
Copy link
Member

miq-bot commented Mar 17, 2017

Checked commit jntullo@52ae8a3 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. ⭐

@abellotti
Copy link
Member

Thanks @jntullo for adding the tests 😍

@abellotti abellotti added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 17, 2017
@abellotti abellotti merged commit 346382d into ManageIQ:master Mar 17, 2017
@jntullo jntullo deleted the enhancement/enable_put_method branch November 28, 2017 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants