Add test coverage for Embedded Ansible and eliminate redundant spec code

[jameswnl]

• The 2 sets of specs are essentially the same between EmbeddedAnsible from AnsibleTower
• After branching out EmbeddedAnsible from AnsibleTower, there have been new enhancements added and the new specs are only covering AnsibleTower.

This PR is to make the 2 sets of specs to use shared_examples to solve the above issues. Also make future enhancements easier to add test coverage without parity between the two.

@miq-bot add_labels refactoring, test, providers/ansible_tower

[miq-bot]

Some comments on commits jameswnl/manageiq@eb6be29~...c2465a8

spec/support/ansible_shared/automation_manager/configuration_script.rb

• ⚠️ - 39 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

spec/support/ansible_shared/automation_manager/job.rb

• ⚠️ - 115 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 144 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 72 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

[miq-bot]

Checked commits jameswnl/manageiq@eb6be29~...c2465a8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
30 files checked, 7 offenses detected

spec/support/ansible_shared/automation_manager/configuration_script_source.rb

• ❗ - Line 23, Col 9 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 24, Col 9 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 25, Col 9 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

spec/support/ansible_shared/automation_manager/credential.rb

• ❗ - Line 21, Col 9 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 22, Col 9 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 23, Col 9 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

spec/support/ansible_shared/provider.rb

• ❗ - Line 29, Col 48 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

[jameswnl]

@jrafanie this is the one I talked to you about.

[blomquisg]

This is purely test refactoring and tests are passing, so...

[durandom]

yay, it's gonna be a fun time extracting ansible into an external provider