Make Widget run without timezones

[kbrock]

Summary

A Widget is basically a Report that is customized for a user's security group and time zone.

Before

Some report data is different for each time zone.
So all reports are run for each user security group and each time zone.
Note: only time zones that are used by users in the security group are populated.

Change

But many reports just show tallies that are the same regardless of the user's time zone.

This PR marks widgets that are not affected by time zone, so they can be run once per time zone.

Conclusion

For my test customer:

50% less time is spent running these 3 reports.
The 10 minute savings per hour is 20% less load on the reporting worker.

Numbers

Widget	runs before	runs after	ms/run	rows/run	before*	after*
Top Storage Consumers	144	71	5,255.9	1,148	12.6m	6.2m
Vendor and Guest OS Chart	152	74	3,374.8	1,148	8.5m	4.2m
Guest OS Information	7	3	4,127.8	2,280	29s	12s

* before and after are estimated. Took too much time to run these.

Related items

• https://bugzilla.redhat.com/show_bug.cgi?id=1251259
• Speed up widget generation #14224
• Report Widget #14285

[jrafanie]

I like this approach @kbrock, very nice! Checkout the failing tests Would you be able to create a test case that covers both the timezone_matters? and !timezone_matters case?

[kbrock]

@jrafanie Failing test was one of the modified yaml files. (yay failing tests catching dev changes)

So I put in tests around generating content.

[jrafanie]

Looks good, I have a few questions/suggestions.

[jrafanie]

wow, we don't use this? 🥇

[jrafanie]

is this a hash? Can we do options.fetch(:timezone_matters, true) instead?

[jrafanie]

I think that's right, default to true

[kbrock]

Unfortunately, options can be nil.

  #A pr code:
    options.try(:[], :timezone_matters) != false
  #B using fetch:
    options ? options.fetch(:timezone_matters, true) : true
  #C using fetch 2:
    (options || {}).fetch(:timezone_matters, true)

[jrafanie]

Wow, good point @kbrock. Personally, I'd use a guard clause to make things very explicit:

Maybe something like this:

def timezone_matters?
  return true unless options
  options.fetch(:timezone_matters, true)
end

If we ever make options default to an empty hash, we could easily remove that guard clause.

[Fryguy]

I like choice C or @jrafanie's personally

[chessbyte]

why is options ever nil?

[jrafanie]

@kbrock is there a BZ for this? does it need to be backported?

[kbrock]

https://bugzilla.redhat.com/show_bug.cgi?id=1251259 - think it would be good in e, but 5.8 means f?

[miq-bot]

Checked commits kbrock/manageiq@1a4ce7f~...0a2c5f9 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks good. 🍪

[simaishi]

Euwe backport details:

$ git log -1
commit 102f688f4ef1af978a7f039a04fcb090d0508951
Author: Joe Rafaniello <[email protected]>
Date:   Mon Mar 20 16:52:26 2017 -0400

    Merge pull request #14386 from kbrock/widget_timezones
    
    Make Widget run without timezones
    (cherry picked from commit c9cf15216a416a654def816e4d79acc62e520000)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1434150