Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix services always invisibile #14403

Merged
merged 1 commit into from
Mar 20, 2017
Merged

Conversation

bzwei
Copy link
Contributor

@bzwei bzwei commented Mar 20, 2017

Fixed a bug introduced by #13800.

The existing code uses the attributes whose keys are mixed with strings and symbols. The display attribute was forced to set to false always.

This fix eliminates the confusion by normalizing every key to string.

@miq-bot add_label bug
@miq-bot add_label automate
@miq-bot assign @gmcculloug

cc @tinaafitz @imtayadeway

@miq-bot
Copy link
Member

miq-bot commented Mar 20, 2017

Checked commit bzwei@0e52909 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. ⭐

@gmcculloug gmcculloug merged commit ca7ced8 into ManageIQ:master Mar 20, 2017
@gmcculloug gmcculloug added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 20, 2017
@bzwei bzwei deleted the service_display branch March 20, 2017 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants