Add a add_to_service method to Vm #14416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gmcculloug @jntullo @abellotti |
gmcculloug
reviewed
Mar 20, 2017
| @@ -6,7 +6,7 @@ def remote_console_url=(url) | |||
|
|
|||
| def add_to_service(service) | |||
| raise ArgumentError, "service must be a MiqAeServiceService" unless service.kind_of?(MiqAeMethodService::MiqAeServiceService) | |||
| ar_method { wrap_results(Service.find_by(:id => service.id).add_resource!(@object)) } | |||
| ar_method { wrap_results(@object.add_to_service(Service.find(service.id))) } | |||
There was a problem hiding this comment.
Should continue to use find_by(:id => service.id).
|
Checked commits mkanoor/manageiq@11cb5cb~...c13b5fd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/n/projects/1937537/stories/142057167
Any object that can be added to a service should have a method called add_to_service.