Revert "Remove unneeded include from reports" #14439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3af1aeb.
1 task
|
Checked commit kbrock@d6418be with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Looks good to me. Thx @kbrock 👍 |
|
Looks good to me too 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3af1aeb (from #13675 )
#13675 was not working properly with
MiqReport#build_reportable_data. Columns were missing from the UI BZ 1422584 #14115This PR adds the removed
includevalues back into the report definitions.They will be removed in the future once
build_reportable_datahas been fixed to readsort_colsorincludes/cc @gtanzillo @martinpovolny
links: https://www.pivotaltracker.com/n/projects/1619581