Added Api::Utils.resource_search_by_href_slug helper method #14443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
abellotti
commented
Mar 21, 2017
abellotti
commented
- Added Api::Utils.resource_search_by_href_slug helper method
- Added related rspec
Added related rspec
|
/cc @Fryguy @mkanoor @gmcculloug as promised, please review. Thanks. |
|
Easily my second favorite href_slug related PR of the day. 😃 Thanks for getting this out. 👍 |
mkanoor
reviewed
Mar 22, 2017
lib/api/utils.rb
Outdated
| @@ -5,5 +5,15 @@ def self.build_href_slug(klass, id) | |||
| collection = Api::CollectionConfig.new.name_for_subclass(klass) | |||
| "#{collection}/#{id}" if collection | |||
| end | |||
|
|
|||
| def self.resource_search_by_href_slug(href_slug) | |||
There was a problem hiding this comment.
@abellotti can we pass in the user_object here with the default being User.curent_user
def self.resource_search_by_href(href_slug, user = User.current_user)
There was a problem hiding this comment.
Sure, didn't know the usage from your side. Will update. 👍
abellotti
force-pushed
the
api_resource_search_by_href_slug
branch
from
ae4ce20
to
d5eddfd
Compare
User.current_user or specified user must be specified Updated tests for the new signature
abellotti
force-pushed
the
api_resource_search_by_href_slug
branch
from
d5eddfd
to
d727f00
Compare
|
@mkanoor updated as discussed. Thanks!! |
|
Checked commits abellotti/manageiq@2c618ab~...d727f00 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
👍 |
|
anything else needed here ? can this be merged ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.