Enable scm_credential type in refresh #14471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_labels wip, enhancement, providers/ansible_tower |
|
Checked commit jameswnl@fcea79e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/models/manageiq/providers/ansible_tower/shared/inventory/parser/automation_manager.rb
|
jameswnl
changed the title
|
@miq-bot remove_label wip |
|
@durandom help take a quick look. UI is blocked on this. |
durandom
approved these changes
Mar 23, 2017
| @@ -1,7 +1,7 @@ | |||
| require 'support/ansible_shared/automation_manager/refresher' | |||
| require 'support/ansible_shared/automation_manager/refresher_v2' | |||
There was a problem hiding this comment.
wow... i.e. we never tested the _v2 refresh?!
There was a problem hiding this comment.
we did at one point 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
scm_credentialwas not being inventoried with most accurate class type.Also fixing a test
shared_examplesbeing directed to wrong file.