flag required attributes for Ansible credentials #14474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label enhancement, providers/ansible_tower |
Fryguy
approved these changes
Mar 23, 2017
|
Checked commit jameswnl@814f477 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Needed (or referenced) by #14217 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As hint to UI to enforce some minimal checking on user input for creation.
(There is 2 more attributes not being modeled here:
namewhich is part ofAuthenticationand it is always required for all Ansible credentialsorganization, or team, or userwhich Tower requires at least one of them. Previously we agreed on always default to theDefaultorganization that comes with vanilla Tower. The question is who would enter that? UI, or API, or model@Fryguy @blomquisg what do you think on the 2nd bullet?
)